forked from openedx/edx-platform
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add API to return list of downstream contexts for an upstream #739
Closed
rpenido
wants to merge
14
commits into
navin/fal-4006/course-libraries-page
from
rpenido/fal-4005/list-courses-using-library
Closed
feat: add API to return list of downstream contexts for an upstream #739
rpenido
wants to merge
14
commits into
navin/fal-4006/course-libraries-page
from
rpenido/fal-4005/list-courses-using-library
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4ad01b
to
4516aa2
Compare
rpenido
commented
Feb 14, 2025
@@ -29,6 +29,11 @@ | |||
downstreams.UpstreamListView.as_view(), | |||
name='upstream-list' | |||
), | |||
re_path( | |||
f'^upstream/{settings.USAGE_KEY_PATTERN}/downstream-contexts$', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not happy with my URL choice here. I was trying to have a structure like parent/{parentId}/children instead of children/{parentId}, but I`m not sure if this is clear close to the other endpoints.
Do you think there is a better way to make it consistent with the other URLs?
4516aa2
to
88e9b08
Compare
These app models get pulled in when trying to build the OpenAPI docs so we need their relevant apps installed into the environment used to generate the docs.
The format of the `source_suffix` setting has change but the default is fine for us so we don't need to override this.
Adds api for listing upstream entity links for a given course.
chore: Update xblocks-contrib pypi package Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`
…contrib-a1d0826 feat: Upgrade Python dependency xblocks-contrib
…x#35612) * feat!: upgrading api to DRF
…6199) * fix: Render Word cloud and conditional block editor - The xmodule-type to render is MetadataOnlyEditingDescriptor - The xmodule type `MetadataOnlyEditingDescriptor` renders a `<div>` with the block metadata in the `data-metadata` attribute. But is necessary to call `XBlockEditorView.xblockReady()` to run the scripts to build the editor using the metadata. - To call XBlockEditorView.xblockReady() we need a specific require.config * fix: Adding save and cancel button * fix: save with studio_submit of conditional_block and word_cloud_block * test: Tests for studio_submit of conditional and word cloud * revert: Delete studio_submit of conditional block. It is not supported * style: Fix lint --------- Co-authored-by: Navin Karkera <[email protected]>
…edx#35852)" This reverts commit 9274852.
Co-Authored-By: Feanil Patel <[email protected]>
feanil/fix docs build
5ca5d06
to
5d21ba3
Compare
c752f6d
to
e92aa0f
Compare
e92aa0f
to
c8bbff9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See openedx/frontend-app-authoring#1656